Re: [PATCH]: DatagramChannel + Misc. Channel Fixes

[Michael Koch <konqueror at gmx dot de>]

On Sun, Feb 01, 2004 at 01:45:25PM -0600, Mohan Embar wrote:
> Hi Michael,
> 
> >Can you recreate this as unified diff please ? Its much more readbale.
> 
> Here you go....

Now I go ...

> -        int len = dst.remaining();
> +        int len = dst.capacity() - dst.position();

Why is this needed ? This means that we write probably more data into
the buffer then is suitable. I think we have to honor limit(). This is
automatically done by using remaining().

Can you write a little example proving I'm wrong ? (not that big NetTest
suite.


> -    int len = dst.remaining();
> +    int len = dst.capacity() - dst.position();

Same here.



Michael