This is the mail archive of the mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Alpha Patch: Busted in 3.4

On Thu, Jan 29, 2004 at 02:53:09PM -0600, Mohan Embar wrote:
> Hi Michael,
> Thanks for looking at this.
> >I dont like the inIOOperation thingie but there is no better solution
> >exception "extending" SUNs API (AbstractSelectableChannel).
> I don't care for it either, but I couldn't think of any other way.
> On the other hand, I now have inIOOperation in two places:
> ServerSocketChannelImpl and SocketChannelImpl. I think I
> can move this to PlainSocketImpl and avoid the duplication.
> What do you think? (Remember that SocketChannelImpl and
> ServerSocketChannelImpl <i>must</i> use PlainSocketImpl
> and are not allowed to have a custom implementation.)

Sounds like the right way.

> >I'm okay with the patch and this surely has to go into trunk. I dont
> >think think this can go into branch but it should. Tom has to decide.
> I'll check out and build the trunk now.

I could have done this for you too, branch is not too different in this
parts of code. But trunk is the future ;-).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]