This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: unused arguments


>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> I just wrote a little patch to suppress two warnings about
Michael> unused arguments.  This generally adds
Michael> "__attribute__((unused))". This gives no warning when the
Michael> argument is used.

Michael> 	* jni.cc (_Jv_LookupJNIMethod): Mark 'args_size' unused.
Michael> 	* verify.cc (debug_print): Mark 'fmt' unused.

Like we talked about on irc, I'd prefer we:

#define MAYBE_UNUSED __attribute__ ((__unused__))

in a .h somewhere and then use `MAYBE_UNUSED' with the parameters.  I
find this slightly clearer, since the parameters are in fact only
unused in some configurations.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]