This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: handle menubar disposal


On Tue, 2004-01-27 at 12:03, Thomas Fitzsimmons wrote:
> 
> When you add a file to the build, you need to include the Makefile.am
> differences in the patch.  You also need to regenerate Makefile.in
> before checking it in (but don't include Makefile.in in the patch).
> 
> +  if (!GTK_IS_MENU_SHELL (children->data))
> +    return;
> 
> When will this happen?  Can you add a small explanatory comment?
> 
> +  else
> +    mptr = children->data;
>    gtk_container_remove (GTK_CONTAINER (box), GTK_WIDGET (mptr));  
> 
> We should probably have a comment that removing the menu bar causes its
> GTK reference count to drop -- I think we were surprised by that.

Checked in the following patch.

Cheers,

Kim

Attachment: AWT-menu-disposal.patch.post
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]