This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH]: use MenuBar requisition as height
- From: Thomas Fitzsimmons <fitzsim at redhat dot com>
- To: Kim Ho <kho at redhat dot com>
- Cc: java-patches <java-patches at gcc dot gnu dot org>
- Date: Sat, 24 Jan 2004 22:01:52 -0500
- Subject: Re: [PATCH]: use MenuBar requisition as height
- References: <1074894085.6969.7.camel@tomaluk.toronto.redhat.com>
On Fri, 2004-01-23 at 16:41, Kim Ho wrote:
> Hi,
>
> This patch uses menubar's requisition as the height instead of waiting
> for size-allocate signals to be sent. This allows for the proper
> position of components when the menubar is set before show is called.
>
> Also overrides setBounds and postInsetsChangedEvent to adjust the top
> inset since it includes the menubar height.
>
> Cheers,
>
> Kim
>
> 2004-01-23 Kim Ho <kho@redhat.com>
>
> * gnu/java/awt/peer/gtk/GtkFramePeer.java (menuBarHeight): Mark
> private.
> (setMenuBar): Grab MenuBar height and change insets.
> (setBounds): Account for MenuBar height.
> (postInsetsChangedEvent): ditto.
^
Little nit: change log entries should always start with an uppercase
letter.
Otherwise, looks good.
Tom