This is the mail archive of the
mailing list for the Java project.
Re: FYI: Patch: java nio file locking
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Michael Koch <konqueror at gmx dot de>, Per Bothner <per at bothner dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 23 Jan 2004 17:20:37 -0600
- Subject: Re: FYI: Patch: java nio file locking
- Reply-to: gnustuff at thisiscool dot com
>> I would prefer a single natFileChannelImpl.cc too but the windows people
>> namely Mohan Embar requested the split.
>I wonder why. It means it makes it difficult to share code in the native
>methods. That in turn encourages extra methods that do some checking in
>Java before calling a native methods htat does the work.
I'd prefer split files for the same reason we decided to split the networking
Initially, I was resistant to this idea:
...but this post convinced me otherwise:
The memory-mapped I/O code will probably be radically different between
POSIX and Win32. I'd be interested in weighing the amount of common code
versus OS-specific code in an #ifdef-ed solution. And putting on my
Win32 libgcj reviewer hat, I'm not really interested in having to move heaven
and earth if I want to put in a Win32-specific change, but have to stress
out about breaking the POSIX world.