This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gen-classpath-compare


On Thu, Jan 22, 2004 at 03:35:04PM +0100, Gerald Pfeifer wrote:
> On Wed, 21 Jan 2004, Michael Koch wrote:
> > there page is very simple: an explaining text at the top and a big
> > table. This table shows differences between libgcj and classpath.
> > Each row contains the class name and type of difference (sometimes with
> > a link to the diff). There are in general 7 types of differences.
> > 
> > 1) class only exist in classpath.
> > 2) class only exist in libgcj.
> > 3) class is VM specific.
> > 4) class is GCJ specific (special case of 2)
> > 5) class exist in both but are not merged.
> > 6) class is merged but there are unexpected differences.
> > 7) class is merged with expected differences.
> > 
> > Totally merged classes are not listed (yet).
> 
> Okay, so we need to come up with proper CSS class names for these seven.
> 
> How about
> 
>   classpath-only
>   libgcj-only
>   VM-specific
>   GCJ-specific
>   needsmerge
>   mergeddiff
>   merged

Tom Tromey and I spoke on IRC about this. I forgot one type because we
dont show it yet: fully merged classes.

So we need "merged" for fully merged classes and "mergeexpected" for 7.

> ?  And which colors should I initially assign to these?

We really have no preferences for the colors. My proposal would be would
be to make merged and specific classes (1-4) green, merged classes
(6 + 7) orange or yellow and unmerged classes (5) red. It would probably
be nice to have unique color for every type to distinguish easier. I
dont know if thats possible with green for 5 types.


Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]