This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: fix GtkTextFieldPeer's preferred and minimum size calculations


>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch fixes GtkTextFieldPeer's preferred size and minimum size
Tom> calculations.  Previously, the preferred and minimum size methods always
Tom> returned the actual size of the backing GtkEntry widget, causing
Tom> TextField components to be laid out incorrectly.
Tom> OK to commit?

Yes, thanks.

Tom> +      /* FIXME: use gtk_entry_set_invisible_char (GtkEntry *entry,
Tom> +	 gunichar ch) here.  That means we must convert from jchar
Tom> +	 (utf16) to gunichar (ucs4). */

Given that we don't support surrogate characters (though there's a
proposal or clarification on this... someday we should look at it :-)
I think this is as easy as just widening each character.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]