Re: [PATCH] Modal FileDialog implementation.

[Fernando Nasser <fnasser at redhat dot com>]

Thomas Fitzsimmons wrote:
> > !     // Remove any directory path from the filename
> > !     int sepIndex = fileName.lastIndexOf (FS);
> > !     if (sepIndex < 0)
> > !       {
> > !         currentFile = fileName;
> > !         nativeSetFile (fileName);
> > !       }
> > !     else
> > !       {
> > !         if (fileName.length() > (sepIndex + 1))
> > !         {
> > !           String fn = fileName.substring (sepIndex + 1);
> > !             currentFile = fn;
> > !             nativeSetFile (fn);
> > !         }
> > !       else
> > !         {
> > !             currentFile = "";
> > !             nativeSetFile ("");
> > !         }
> > !       }
>
>
> Can the nativeSetFile calls here be replaced by one call after the if
> block?

Of course.  Thanks for spotting it.

> > + static void window_closed (GtkDialog *dialog
> > __attribute__((unused)),
> > +                            gint responseId,
> > +                            jobject peer_obj);
> > + static void ok_clicked (GtkButton *button __attribute__((unused)),
> > +                       jobject peer_obj);
> > + static void cancel_clicked (GtkButton *button
> > __attribute__((unused)),
> > +                           jobject peer_obj);
>
>
> The attributes aren't needed in the function declarations, only in the
> definitions.

OK, I didn't know.  Will remove the extra __attribute__ quals.


Thanks for reviewing it Tom.



--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9