This is the mail archive of the
mailing list for the Java project.
Re: FYI: patch: gnu.java.net.protocol.http.Connection
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Michael Koch <konqueror at gmx dot de>, java-patches at gcc dot gnu dot org
- Date: Mon, 5 Jan 2004 20:40:53 +0000
- Subject: Re: FYI: patch: gnu.java.net.protocol.http.Connection
- References: <firstname.lastname@example.org><email@example.com><20031231120339.GB32622@mail.konqueror.de><firstname.lastname@example.org><email@example.com>
Tom Tromey writes:
> >>>>> "Andrew" == Andrew Haley <firstname.lastname@example.org> writes:
> Andrew> http://gcc.gnu.org/contribute.html#patches
> Andrew> "The ChangeLog entries should be plaintext rather than part of the
> Andrew> patch since the top of the ChangeLog changes rapidly and a patch to
> Andrew> the ChangeLog would probably no longer apply by the time your patch is
> Andrew> reviewed."
> I've been a bit more tolerant on java-patches since this doesn't apply
> to folks who commit their own changes, and since I use
> clcleanup/cl2patch on patches I apply (these scripts handle this
> situation automatically).
> It's also simple enough to run clcleanup on a diff before posting;
> that's what I do.
Yeah, but anything that discourages people from reading patches is
surely a Bad Thing. But I agree this isn't very important: I only
mentioned it because I was replying to the patch anyway.