Re: FYI: patch: gnu.java.net.protocol.http.Connection

[Andrew Haley <aph at redhat dot com>]

Michael Koch writes:
 > On Wed, Dec 31, 2003 at 11:45:24AM +0000, Andrew Haley wrote:
 > > Michael Koch writes:
 > >  > 
 > >  > I commited the attached patch to merge a fix from classpath to encode the 
 > >  > output stream correctly and to put a meaningful htt user agent into the 
 > >  > stream.
 > >  > 
 > >  > 
 > >  > Michael
 > >  > Index: ChangeLog
 > >  > ===================================================================
 > >  > RCS file: /cvs/gcc/gcc/libjava/ChangeLog,v
 > >  > retrieving revision 1.2505
 > >  > diff -u -b -B -r1.2505 ChangeLog
 > >  > --- ChangeLog	31 Dec 2003 11:04:17 -0000	1.2505
 > >  > +++ ChangeLog	31 Dec 2003 11:25:09 -0000
 > >  > @@ -1,3 +1,9 @@
 > >  > +2003-12-31  Michael Koch  <konqueror@gmx.de>
 > >  > +
 > >  > +	* gnu/java/net/protocol/http/Connection.java
 > >  > +	(sendRequest): Dont encode output in default character encoding,
 > >  > +	add correct version number to HTTP user agent string.
 > >  > +
 > > 
 > > ChangeLog not in diff format please.
 > > Also:
 > > 
 > > 	* gnu/java/net/protocol/http/Connection.java (sendRequest):
 > > 	Don't encode output in default character encoding.  Add
 > > 	correct version number to HTTP user agent string.
 > 
 > Hmm, I always did that in the past and noone complained until. What is
 > wrong with ChangeLog entry included in the diff or do you mean that I
 > should include the changelog entry int he message in the future ?

http://gcc.gnu.org/contribute.html#patches

"The ChangeLog entries should be plaintext rather than part of the
patch since the top of the ChangeLog changes rapidly and a patch to
the ChangeLog would probably no longer apply by the time your patch is
reviewed."

Andrew.