Re: FYI: Patch: javax.print.attribute

[Joerg Brunsmann <joerg_brunsmann at yahoo dot de>]

Hi Michael,

great to see so many patches. Here's a quick review of your latest.

+  /**
+   * Creates an empty <code>HashAttributeSet</code> object.
+   *
+   * @exception ClassCastException if any element of attributes is not an
+   * interface of interfaceName
+   * @exception NullPointerException if attributes or interfaceName is null
+   */
+  public HashAttributeSet(AttributeSet attributes, Class interfaceName)
+  {
+    this(interfaceName);
+    
+    if (attributes != null)
+      addAll(attributes);
+  }

The comment is wrong; if parameter 'attributes' is 'null' no 
NullPointerException is thrown?

+  /**
+   * Adds the given attribute to the set.
+   *
+   * @param attribute the attribute to add
+   *
+   * @return true if the attribute set has changed, false otherwise
+   */
+  public boolean add(Attribute attribute)
+  {
+    if (attribute == null)
+      throw new NullPointerException("attribute may not be null");
+
+    Object old = attributeMap.put
+      (attribute.getCategory(), AttributeSetUtilities.verifyAttributeValue
+                                  (attribute, interfaceName));
+    return !attribute.equals(old);
+  }

Missing @exception tag in comment?

+  /**
+   * Adds the given attributes to the set.
+   *
+   * @param attributes the attributes to add
+   *
+   * @return true if the attribute set has changed, false otherwise
+   */
+  public boolean addAll(AttributeSet attributes)
+  {
+    boolean modified = false;
+    Attribute[] array = attributes.toArray();
+
+    for (int index = 0; index < array.length; index++)
+      if (! add(array[index]))

Do you need to negate the expression?

+        modified = true;
+
+    return modified;
+  }

Keep those patches coming ;-)

Jörg

__________________________________________________________________

Gesendet von Yahoo! Mail - http://mail.yahoo.de
Logos und Klingeltöne fürs Handy bei http://sms.yahoo.de