Re: [PATCH] [MinGW]: Reset/Ignore Thread Interruption for Plain[Datagram]SocketImpl

[Michael Koch <konqueror at gmx dot de>]

On Mon, Dec 15, 2003 at 09:49:26AM -0600, Mohan Embar wrote:
> >> >I dont know enough about the threading stuff. I would like if Tom or
> >> >Bryce or Andrew can approve such type of changes. The other (case
> >> >changing) things are okay.
> >> 
> >> This is a Win32-specific patch, so I think that Tom empowered me to
> >
> >Ah, now I see, I commited the SocketTimeoutException stuff to the Posix
> >part and we/you forgot it for the Win32 stuff until now.
> 
> Um, we're getting our patches confused here:
> 
> - the SocketTimeoutException is my POSIX patch. In natPlainDatagramSocketImplWin32,
>   I changed these from InterruptedIOExceptions to SocketTimeoutExceptions long
>   time ago with my cleanup/networking patch, but POSIX is still incorrect and needs
>   to be fixed.
> 
>   May I commit this?:
> 
>   http://gcc.gnu.org/ml/java-patches/2003-q4/msg00738.html

Damn commit this but make the exception messages consistent (uppercase
if you want).

> - the interruptible Selector.select() patch for Win32:
> 
>   http://gcc.gnu.org/ml/java-patches/2003-q4/msg00733.html
> 
>   I'm okay with this, but wanted to leave it on the list because Tom
>   sometimes catches formatting standards snafus and sometimes
>   makes insightful comments on the Win32 code.
> 
> - the reset/ignore thread interrupt status patch for Win32:
> 
>   http://gcc.gnu.org/ml/java-patches/2003-q4/msg00736.html
> 
> My plan was to commit the latter two after letting them sit on the list
> for a couple of days, but I need someone else's approval before
> committing the first one.

I think I got somehow confused because one patch you submitted was in
the middle of another thread (of another patch). I think thats because
you wrote the patch mail by replying to one of the thread's mails. Good
MUAs will thread this ;-)


Michael