This is the mail archive of the
mailing list for the Java project.
Re: [PATCH] Fix to KEY events
- From: Thomas Fitzsimmons <fitzsim at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Fernando Nasser <fnasser at redhat dot com>, GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Wed, 03 Dec 2003 15:29:32 -0500
- Subject: Re: [PATCH] Fix to KEY events
- References: <3FCE388E.firstname.lastname@example.org> <email@example.com>
On Wed, 2003-12-03 at 14:54, Tom Tromey wrote:
> >>>>> "Fernando" == Fernando Nasser <firstname.lastname@example.org> writes:
> Fernando> Most credits should go to Tom Fitzsimmons, but here is a fix
> Fernando> for an annoying problem that would make any keypress (even a
> Fernando> SHIFT key one) cause a checkbox to toggle, buttons to appear
> Fernando> to have been pressed etc.
> Fernando> + /* XXX We don't know what the intention was here, but
> Fernando> + this is definitively _not_ the right thing to do
> Fernando> gtk_widget_activate (window->focus_widget);
> Fernando> + */
> Normally we just delete unused code. Is it likely this code will be
> resurrected in the near future? If not, let's just remove it.
> Anyway, this is ok.
> Hmm, I was going to say that we usually write "FIXME" instead of
> "XXX", but grep shows that both seem to be pretty common. Learn
> something every day :-)
Maybe we should use "XXX" for "I'm not sure about this:" and "FIXME" for
"This is a problem but we can fix it later:".