Re: [PATCH] [MinGW] for Review: Add UNICODE support to MinGW libgcj(UPDATED)

[Ranjit Mathew <rmathew at hotmail dot com>]

Mohan Embar wrote:
> - whether I'm allowed to introduce a new libgcj configure
>   switch (--enable-libgcj-mingw-osapi) and if so, whether it
>   is aptly named

Wouldn't "--with-win32-nlsapi={ansi,unicode,unicows}"
be better? This is because IMHO the "--with" style
more accurately reflects what you want to do and
because this option can possibly be used one day to
decide what to use for libstdc++-v3 on MinGW (and
possibly other libraries).

With the above, you'll also have to get a nod
from MinGW and Cygwin developers, though I don't
expect them to pour vitriol on you for this. :-)


> - whether the AC_DEFINE MINGW_LIBGCJ_UNICODE
>   is aptly named

FWIW, I agree with Tom that the "LIBGCJ" part
in the name is redundant because of where it
gets defined.

I'm sorry, but I haven't had the time to comb
through your patch in its entirety (but apparently
had enough time to participate in flame-wars ;-)).

Ranjit.

-- 
Ranjit Mathew          Email: rmathew AT hotmail DOT com

Bangalore, INDIA.      Web: http://ranjitmathew.tripod.com/