This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Label fixes


>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch reverts the change made here:
Tom> 2003-07-24  Thomas Fitzsimmons  <fitzsim@redhat.com>
Tom> 	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkLabelPeer.c (create):
Tom> 	Don't pack label in an event box.
Tom> and implements new methods that "unwrap" the label from the event box.

This looks good, thanks.  Just one comment...

Tom> +JNIEXPORT void JNICALL
Tom> +Java_gnu_java_awt_peer_gtk_GtkLabelPeer_setText
Tom> +  (JNIEnv *env, jobject obj, jstring text)
Tom> +{
Tom> ...
Tom> +  str = (*env)->GetStringUTFChars (env, text, 0);

You never release the characters in this function.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]