This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] java/12857: Fix class literals
- From: Tom Tromey <tromey at redhat dot com>
- To: Jeff Sturm <jsturm at one-point dot com>
- Cc: Andrew Haley <aph at redhat dot com>, java-patches at gcc dot gnu dot org, <gcc-patches at gcc dot gnu dot org>
- Date: 07 Nov 2003 11:46:03 -0700
- Subject: Re: [PATCH] java/12857: Fix class literals
- References: <Pine.LNX.4.44.0311070827330.10628-100000@ops2.one-point.com>
- Reply-to: tromey at redhat dot com
>>>>> "Jeff" == Jeff Sturm <jsturm@one-point.com> writes:
>> What Mauve failures?
Jeff> See below. All of these appear to be serialization failures.
Jeff> The patch surely did affect class layout, but I could not easily see how
Jeff> these tests are affected. For example, running serialver on the mauve
Jeff> tests before and after patching did not reveal any change.
It looks to me that the tests rely on the serialver being consistent
across compilers, as there is sample data checked in. This is not a
valid thing to do... compilers generate different code and cannot
easily be made serialization-compatible with Sun's compiler. See the
various discussions of this point on this list in the past for more
details.
Probably the serializable Test$* classes in Mauve need their UID set
explicitly, like we do in the library.
Tom