This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] PR/12647: MinGW: Respect refcount in _Jv_CondWait
- From: Tom Tromey <tromey at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: java-patches at gcc dot gnu dot org
- Date: 24 Oct 2003 12:07:07 -0600
- Subject: Re: [PATCH] PR/12647: MinGW: Respect refcount in _Jv_CondWait
- References: <OMICIFLFE9ELA8TQPHETPK32F006.3f98593a@p733>
- Reply-to: tromey at redhat dot com
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
Mohan> I could go either way on this. pthread_mutex_init creates a
Mohan> fast mutex on Linux by default, whereas Win32
Mohan> InitializeCriticalSection() always creates a recursive
Mohan> mutex. Part of me likes the simplicity of your solution, but
Mohan> part of me says that by leaving the Windows code the way it is,
Mohan> we could potentially more easily catch future errors in the
Mohan> library which don't have matching _Jv_MutexLock /
Mohan> _Jv_MutexUnlock calls.
Either way is ok by me. I think your patch as-is is fine.
Tom