Re: Path: Compute user.home properly on MinGW

[Bryce McKinlay <bryce at mckinlay dot net dot nz>]

Hi Mohan,

If you're satisfied that this is an improvement over what we have 
currently then go ahead and check in this patch. It looks ok to me. The 
only thing I'd suggest is changing the name of "computeUserHome" to 
"getUserHome" as this would be more consistent with the names we use 
elsewhere.

Regards

Bryce.


On Oct 15, 2003, at 12:03 AM, Mohan Embar wrote:

> Hi All,
>
> This attempts to fix the issues computing user.home
> which Taras reported here:
>
> http://gcc.gnu.org/ml/java/2003-10/msg00046.html
>
> It also attempts to support legacy versions of
> Windows (9X and NT).
>
> Taras: Can you take a glance at this?
>
> -- Mohan
> http://www.thisiscool.com/
> http://www.animalsong.org/
>
> ChangeLog
> 2003-10-14  Mohan Embar  <gnustuff@thisiscool.com>
>
> 	* win32.cc: (dirExists) Internal helper function to
> 	test for directory existence.
> 	(computeUserHome) New helper function refactored out
> 	of _Jv_platform_initProperties. Uses USERPROFILE
> 	instead of HOMEDIR and attempts to support Win9X and NT.
> 	(_Jv_platform_initProperties) Use computeUserHome.