This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [JAVA PATCH] SAVE_EXPR evaluate-once semantics in jcf-write.c


Andrew Haley wrote:

 > To conclude, this patch is certainly not a workaround.  Whenever
 > generate_bytecode_insns encounters a SAVE_EXPR it has to ensure
 > that its only ever evaluated once.  Those are the semantics of
 > SAVE_EXPR.  Even if we eventually manage to remove/replace all
 > SAVE_EXPRs from the tree, the SAVE_EXPR case of this switch either
 > needs the implementation proposed by my patch or to call abort.
 > The current scheme of silently generating bad code is "right out".

True. I'm minded to accept this patch, but I'll defer to Per.

Likewise (except for the defer-to-Per part!). -- --Per Bothner per@bothner.com http://per.bothner.com/



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]