This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] natString.cc: Some fixes for bounds checking arithmetic.
- From: Tom Tromey <tromey at redhat dot com>
- To: Ralph Loader <suckfish at ihug dot co dot nz>
- Cc: java-patches at gcc dot gnu dot org
- Date: 23 Sep 2003 11:45:08 -0600
- Subject: Re: [Patch] natString.cc: Some fixes for bounds checking arithmetic.
- References: <1064299407.31663.63.camel@localhost.localdomain>
- Reply-to: tromey at redhat dot com
>>>>> "Ralph" == Ralph Loader <suckfish@ihug.co.nz> writes:
Ralph> libgcj contains many places where checking of array index arguments
Ralph> passed to methods is done incorrectly.
Nice work.
Ralph> One of the test cases in the patch is commented out - it causes a
Ralph> warning during the link, which seems to cause the test to fail
Ralph> extraneously. If someone can tell me how to turn off or ignore the
Ralph> warning message, I will do so and uncomment the test case.
Do you get a warning because String.getBytes is deprecated?
There's no way to change the options for just one file. But we
should probably run the test suite with -Wno-deprecated anyway --
that should be easy to change in lang.exp.
I wonder if these tests should go in Mauve instead. Then they'll be
shared with other free VMs.
Tom