This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Trying to merge java.lang.Float, java.lang.Double with Classpath -- help wanted


On Monday, Sep 22, 2003, at 08:35 Pacific/Auckland, Nathanael Nerode wrote:

This was an attempt to merge java.lang.Float and java.lang.Double with
Classpath.

2003-09-21 Nathanael Nerode <neroden@gcc.gnu.org>

	* Makefile.am: Add VMDouble.java, VMFloat.java, natVMDouble.cc,
	natVMFloat.cc; remove natFloat.cc.
	* Makefile.in: Regenerate.
	* java/lang/VMDouble.java: New class, adapted from Classpath's
	vm/reference/java/lang/VMDouble.java.
	* java/lang/VMFloat.java: New class, adapted from Classpath's
	vm/reference/java/lang/VMFloat.java.
	* java/lang/natFloat.cc: Moved to natVMFloat.cc.
	* java/lang/natVMFloat.cc: Moved from natFloat.cc and modified
	appropriately.
	* java/lang/natVMDouble.cc: New file, consisting of methods
	pulled from natDouble.cc and modified appropriately.
	* java/lang/natDouble.cc: Removed methods present in natVMDouble.cc.


I do not agree with this. The existing java.lang.Number classes in libgcj are a clean design that demonstrates effective use of CNI. Because they consist largely of native code anyway, merging adds little value at the cost of an extra layer of indirection and additional unnecessary classes.

Regards

Bryce.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]