This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Fix "make clean" in libjava (Updated)


>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> I've updated and tested the patch, but would prefer you to take
Mohan> one last glance at it before I feel comfortable putting it in,
Mohan> especially the ChangeLog.

Looks great, please check in.

Mohan> Note: the .d files are still left over after the clean. Is this
Mohan> okay?

I think they can only be deleted by distclean, since they are
initially created by configure.  Feel free to check in a patch that
does this.

Mohan> 	* Makefile.am: (MOSTLYCLEANFILES) Removed libtool objects
Mohan> 	because of command-line-length issues.
Mohan> 	(mostlyclean-local): New target patterned after clean-local
Mohan> 	which recursively deletes all libtool objects using 'libtool rm'.

FYI, ordinarily the ChangeLog just says what changed; if you need a
rationale, it belongs in the code, so that future hackers will be
more likely to see it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]