This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: Remove exception catching from normal path in Arrays.equals.
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Andrew Haley <aph at redhat dot com>
- Cc: tromey at redhat dot com, java-patches at gcc dot gnu dot org
- Date: Tue, 09 Sep 2003 12:42:15 -0500
- Subject: Re: Patch: Remove exception catching from normal path in Arrays.equals.
- Reply-to: gnustuff at thisiscool dot com
Hi Andrew,
> > Let me know if you want me to submit a patch. Otherwise, I'll walk
> > away from this.
>
>Sure, go ahead. I'm a bit nervous about the throw new RuntimeError
>part because some broken libgcj targets still don't have working
>backtrace. Perhaps it needs to be conditional on HAVE_BACKTRACE.
I'll submit a patch for this. I thought about the conditional HAVE_BACKTRACE
too. The crux of the question is: on failure, should the helper method do
some sort of exception throwing or return a null value? You said previously
that you didn't like the null checking....
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/