This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Implement native drawString using Pango


On Fri, 2003-08-22 at 14:03, Tom Tromey wrote:
> >>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:
> 
> Tom> This patch changes the native implementation of
> Tom> GdkGraphics.drawString to use Pango text-handling functions.  The
> Tom> existing XLFD implementation was producing completely incorrect
> Tom> output.
> 
> Looks good to me, thanks.
> 
> Tom> +  pango_font_description_free (font_desc);
> 
> Is it expensive to get the pango font description?

pango_font_description_from_string just parses its string argument into
a PangoFontDescription structure -- the function consists of small
mallocs and simple string manipulation.  At this point I'm not going to
worry about caching, though I'll probably revisit this when we start
really profiling our AWT.

Tom



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]