This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch for Review: _Jv_TempUTFString + JV_TEMP_UTF_STRING

From: Bryce McKinlay <bryce at mckinlay dot net dot nz>
To: gnustuff at thisiscool dot com
Cc: tromey at redhat dot com,GCJ Patches <java-patches at gcc dot gnu dot org>,Andrew Haley <aph at redhat dot com>
Date: Fri, 15 Aug 2003 10:50:39 +1200
Subject: Re: Patch for Review: _Jv_TempUTFString + JV_TEMP_UTF_STRING

On Friday, Aug 15, 2003, at 10:06 Pacific/Auckland, Mohan Embar wrote:

Will the nth time be a charm?

Here is the patch, rewritten to use the existing CNI functions.
To recap this supersedes and nullifies the cni.h + gcj.texi
patches as well as all other jvm.h patches.

I'd still like to see it use JvAllocBytes instead of _Jv_Malloc. That way you can get rid of the destructor and the "heapAllocated" field. Even if it were slower, which it isn't, it will only be used in the rare cases where the string is > 256 bytes.

Apart from that, its ok by me.

Regards

Bryce.

Follow-Ups:
- Re: Patch for Review: _Jv_TempUTFString + JV_TEMP_UTF_STRING
  - From: Mohan Embar
- Re: Patch for Review: _Jv_TempUTFString + JV_TEMP_UTF_STRING
  - From: Tom Tromey

References:
- Patch for Review: _Jv_TempUTFString + JV_TEMP_UTF_STRING
  - From: Mohan Embar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]