This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Illegal Package-Private Accesses in 3.4


On Monday, Aug 11, 2003, at 18:45 Pacific/Auckland, Mark Wielaard wrote:

Since NameFinder and StackTrace are both in the same package, wouldn't
a simpler solution be to pass "trace" itself and have NameFinder call
the stackTraceAddrs?

But for not just this, but also for the public access reason (and because StackTrace does have some nice methods that will be useful for implementing some of the SecurityManger things) StackTrace and NameFinder are no longer in the same package (with my patch).

OK, go ahead. I guess StackTrace does conceptually belong in java.lang due to its close relationship with Throwable. In fact, perhaps StackTrace and the VMThrowable class should be merged?


It would be cleaner to keep these things in the same package wherever
possible. If we're worried about user code calling NameFinder being a
security risk, we could add a security check to its constructor.

Then I would vote for moving NameFinder also inside java.lang as package
private.

Actually I think its fine where it is.


Regards

Bryce.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]