This is the mail archive of the mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] unit-at-a-time for java

> I thought I'd give this a try, since it enables effective cross-module
> inlining for gcj.  Following is the patch I'm testing.  There are two
> parts: a patchlet to cgraphunit.c, and the java frontend changes and
> bugfixes I needed to make -funit-at-a-time work.
> Jan, I'm not sure what the comment regarding current_function_decl means.
> However the java inliner requires this to be set to the outermost calling
> function.  I don't know what the impact to C/C++ is.  (If that won't work
> I suppose we could introduce a new variable.)

Your change will work. the inliner just avoids inlining of
current_function_decl so when the current_funcntion_decl is set to
something that we want to inline we lose.  setting it to the function
itself is OK as we don't do recursive inlining yet.
> Calling walk_tree_with_duplicates turned out to be necessary to avoid
> infinite recursion when gathering costs.
this seems to be fine to me too.

thanks for doing all the work! I planned to do it myself sometime but I
had dificulties to find the time so it is great to see it done!

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]