This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] enable double buffering on GtkCanvasPeer
- From: Tom Tromey <tromey at redhat dot com>
- To: "Scott Gilbertson Onsite" <sgilbertson-onsite at cogeco dot ca>
- Cc: <java-patches at gcc dot gnu dot org>, "graydon hoare" <graydon at redhat dot com>
- Date: 18 Jul 2003 11:13:38 -0600
- Subject: Re: [PATCH] enable double buffering on GtkCanvasPeer
- References: <87k7afkg1y.fsf@dub.venge.net><092c01c34d4a$fc40ce10$3c16a8c0@mantatest.com>
- Reply-to: tromey at redhat dot com
>>>>> "Scott" == Scott Gilbertson Onsite <sgilbertson-onsite@cogeco.ca> writes:
Scott> I don't think this patch has been comitted yet.
It hasn't, sorry about that.
The truth is, I'd be happy to have you take over the xlib peers
entirely. You could check in your changes with just an "FYI" patch
posting to java-patches. That is, no more annoying approval step
involving me -- no more delays. (Changes outside the peers would
still require approval, at least for the time being.)
The only barrier is that I've been rewriting your ChangeLog entries to
conform to our coding standards. Let's change this situation, since
I'm sure it will make both of us happier :-)
Here are a couple nice links from Mark Wielaard on writing ChangeLog
entries:
There is more on ChangeLogs in the GNU Coding Standards
<http://www.gnu.org/prep/standards_40.html>
And I like the essay by Jim Blandy "Maintaining the ChangeLog":
<http://www.red-bean.com/cvs2cl/changelogs.html>
Anyway, could you read these and follow the recommendations? I'll
send some info about getting an account set up (I'm assuming this is
the route you want to go -- but at least one person has refused this
in the past...).
The only other thing is that our practice is that the cvs commit
message is the same as the ChangeLog entry.
BTW, thanks for replying on this thread. Sometimes in the gcc
community people who don't have approval power for a patch will often
remain silent even if they have questions, comments, or misgivings. I
think this is something Zack pointed out in his talk at the GCC Summit
(I wasn't there, this is just my recollection from the proceedings).
This bit of culture isn't something we really want to preserve...
Tom