This is the mail archive of the
mailing list for the Java project.
Re: [PATCH] enable double buffering on GtkCanvasPeer
- From: Tom Tromey <tromey at redhat dot com>
- To: graydon hoare <graydon at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 18 Jul 2003 09:36:31 -0600
- Subject: Re: [PATCH] enable double buffering on GtkCanvasPeer
- References: <firstname.lastname@example.org>
- Reply-to: tromey at redhat dot com
>>>>> "graydon" == graydon hoare <email@example.com> writes:
graydon> this patch enables GDK's double buffering on the canvas peer, so that
graydon> it behaves like a "normal" flicker-less GTK widget when you paint into
This is ok, but I have one comment.
graydon> + assert (w);
Shouldn't we use the glib assert macros here? That is the more common
style for gtk code. Actually, some of these asserts are probably just
redundant -- the gtk type-cast macros will complain if we do something
What do you think about that?
It would be cool if you and Tom Fitzsimmons worked out some standards
for how the gtk peers should look. This wouldn't have to be too
formal, just a micro-decisions on stuff like this. I'm ok with
whatever approach you two agree on.