This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] enable double buffering on GtkCanvasPeer


>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> this patch enables GDK's double buffering on the canvas peer, so that
graydon> it behaves like a "normal" flicker-less GTK widget when you paint into
graydon> it.

This is ok, but I have one comment.

graydon> +  assert (w);

Shouldn't we use the glib assert macros here?  That is the more common
style for gtk code.  Actually, some of these asserts are probably just
redundant -- the gtk type-cast macros will complain if we do something
wrong.

What do you think about that?

It would be cool if you and Tom Fitzsimmons worked out some standards
for how the gtk peers should look.  This wouldn't have to be too
formal, just a micro-decisions on stuff like this.  I'm ok with
whatever approach you two agree on.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]