This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: More TextComponent fixes


>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch improves KeyEvent generation, and fixes some problems with
Tom> the AWT TextComponents.  With this patch, the text components can listen
Tom> for key events, including KEY_TYPED events.

Ok.  But a couple notes...

Tom> -  native void createHooks ();
Tom> +  // native void connectHooks ();

Unless you plan to resurrect this at some future point, just go ahead
and delete.  The same holds for commented out debugging printf()s and
"#if 0" code.  The rationale is that we can always find stuff in cvs,
and deleting the dead code makes the live code cleaner.

You don't have to resubmit the patch if you want to go ahead and make
that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]