This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: Account for possible null laddr in Socket.java
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Michael Koch <konqueror at gmx dot de>, gnustuff at thisiscool dot com
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: Mon, 16 Jun 2003 08:25:48 -0500
- Subject: Re: Patch: Account for possible null laddr in Socket.java
- Reply-to: gnustuff at thisiscool dot com
Hi (again) Michael,
>>Yes, this part of the code is a problem. Sorry that I have to say this
>>but I think your patch is half-hearted. raddr can be null too ...
>
>I didn't realize that raddr==null was valid too. Your updated patch
>looks fine....
I'm reading the J2SE 1.4.0 documentation and don't see anywhere
that raddr is allowed to be null. In fact, the documentation for
Socket(InetAddress, int, boolean) seems to imply the contrary
(cf. "If there is a security manager, its checkConnect method is called
with host.getHostAddress() and port as its arguments.").
Nor do I see that we are explicitly passing an raddr==null from
one constructor call to another.
Am I missing something?
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/