This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: java.io.PrintStream
- From: Mark Wielaard <mark at klomp dot org>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 08 Jun 2003 15:55:26 +0200
- Subject: Re: Patch: java.io.PrintStream
- References: <200306081248.18983.konqueror@gmx.de>
Hi,
On Sun, 2003-06-08 at 12:48, Michael Koch wrote:
> I would like to merge java.io.PrintStream from classpath. This
> basically uses a PrintWriter object internally instead of doing it
> all alone.
>
> Can somebody with working Mauve check if this gives any regression ?
Yes, there is the following failure:
FAIL: gnu.testlet.java.io.PrintStream.subclass (number 1)
That test tries to set the protected out variable (of the
FilterOutputStream superclass of PrintStream) and then use it normally.
Which fails with this new PrintWriter delegate thing.
Tricky to get right...
> I somehow can get Mauve working here.
What is the problem? I just checked in a little fix to make mauve work
with gcj (native standalone) again.
> Comments ?
I would loose the synchronized on the write methods. The original libgcj
implementation didn't have them and I don't believe the PrintStreams are
guaranteed to work deterministically when used from multiple Threads.
Cheers,
Mark