Re: Patch for Review: Replace "Unicode to UTF8 conversions" with"Unicode to 'Win32 locale' conversions" when sending/receiving file namesto/from Win32 API.

[João Garcia <jgarcia at uk2 dot net>]

Hi Mohan,

Mohan Embar wrote:
> There is a fourth solution, which would be my preference:
>
> http://libunicows.sourceforge.net/

Thanks. This is useful, but this seems to be only a pratical solution to 
use the already proposed MS UNICOWS with MinGW (it seems we wouldn't be 
able to use ld for the statical part of UNICOWS).

But libunicows.a has 380KB (I don't know how much would be striped...)
I don't know the size of unicows.dll (not included in win9x). And most 
of that code is useless for Java.

If this is the best solution for everybody, I'll have to live with that...


> libunicows works with MingW and the only change to our code
> would be to convert the Win32 A calls to W calls. 

You would also have to change the way you copy the jstring to a 
C-wide-string (that is what the W function expects). It is quite easy to 
do (and I have done it already). But the code is giving me a segfault 
under WinXP (when the W-string has more than 19 chars)... It must be a 
small detail. I'll give it another try soon.

Somebody else could also post a patch for this trivial case (it would 
work without UNICOWS.dll on the NT branch).


> it seems to me that
> any effort we can make to avoid extra maintenance and code
> duplication would be worthwhile, especially given that we are
> dealing with Win9X, which is nearing its end-of life:

I agree with all of you about this objective (nevertheless the tables 
will not change with time... and we could always remove the unnecessary 
code in the future).

I'm only seaching for a viable alternative to solve the win9x problem 
while this platform is still around... and I am not happy with the 
"external" alternatives I have found so far (including your new 
"enhanced" UNICOWS option)..."

I'll keep waiting for someone/anyone/everybody to decide on this subject.


João