This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: libjava/java/io/natFileDescriptorPosix.cc -r1.25 -r1.26
- From: Michael Koch <konqueror at gmx dot de>
- To: Andreas Tobler <toa at pop dot agri dot ch>, Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 16 May 2003 10:11:49 +0200
- Subject: Re: libjava/java/io/natFileDescriptorPosix.cc -r1.25 -r1.26
- References: <200305160337.h4G3bi94068078@latour.rsch.comm.mot.com> <3EC462FC.10607@pop.agri.ch>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am Freitag, 16. Mai 2003 06:03 schrieb Andreas Tobler:
> Loren James Rittle wrote:
> > This patch:
> >
> > 2003-05-13 Michael Koch <konqueror@gmx.de>
> >
> > * java/io/FileDescriptor.java
> > (SYNC): New constant.
> > (DSYNC): Likewise.
> > [...]
> >
> > broke bootstrap on *-*-freebsd[45]. FreeBSD 5 does support
> > O_SYNC but not O_DSYNC. FreeBSD 4 supports neither.
> >
> > I would prefer the patch submitter to fix the problem in some
> > manner. Otherwise, I'd ask whether I need to implement a simple
> > guard around the use of these macros in
> > java/io/natFileDescriptorPosix.cc, or whether we need to throw an
> > implementation error when SYNC/DSYNC was requested at the "java
> > layer" but there was no system support for it.
>
> I have this one for darwin, it may also be valid for *BSD?
> Not reg tested yet.
I commited the attached patch as a tempory fix until this is better
test.
Michael
- --
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+xJ1IWSOgCCdjSDsRApCGAJwLP7As0J5hJNSukgussQ3iKLjmtwCeJbzZ
6iOiAGjxBsJRnETF6Bl7LFI=
=x9zG
-----END PGP SIGNATURE-----
Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libjava/ChangeLog,v
retrieving revision 1.1895
diff -u -b -B -r1.1895 ChangeLog
--- ChangeLog 14 May 2003 06:37:56 -0000 1.1895
+++ ChangeLog 16 May 2003 08:09:14 -0000
@@ -1,3 +1,9 @@
+2003-05-16 Michael Koch <konqueror@gmx.de>
+
+ * java/io/natFileDescriptorPosix.cc
+ (open): Commented out the O_SYNC and O_DSYNC usage until its better
+ tested.
+
2003-05-14 Michael Koch <konqueror@gmx.de>
* gnu/java/nio/FileLockImpl.java
Index: java/io/natFileDescriptorPosix.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/io/natFileDescriptorPosix.cc,v
retrieving revision 1.26
diff -u -b -B -r1.26 natFileDescriptorPosix.cc
--- java/io/natFileDescriptorPosix.cc 13 May 2003 09:13:31 -0000 1.26
+++ java/io/natFileDescriptorPosix.cc 16 May 2003 08:09:14 -0000
@@ -105,11 +105,13 @@
}
}
+/* FIXME: comment this out until its better tested/implemented
if ((jflags & SYNC))
flags |= O_SYNC;
if ((jflags & DSYNC))
flags |= O_DSYNC;
+*/
int fd = ::open (buf, flags, mode);
if (fd == -1 && errno == EMFILE)