This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch(revised): GLightweightPeer,Toolkit allow creation and display of lightweight components


>>>>> "Scott" == Scott Gilbertson <scottg@mantatest.com> writes:

Scott> The attached program (Light.java) runs fine in the JRE, but not
Scott> in gcj.

Thanks for including a test case -- that's nice.

Scott> I tried it on a February 3.3 branch snapshot and on April 29ths
Scott> tip code from cvs.  The attached patch fixes it by implementing
Scott> lightweight peers for Component and Container.  I think this
Scott> patch is essential for javax.swing, because swing uses
Scott> java.awt.Container (lightweight) as the base class for
Scott> JComponent.

Honestly I don't know much about lightweight components.

It seems incorrect to bless one particular lightweight component
implementation in Toolkit.  I think this should depend on the
particular Toolkit.

So I think the code in your Toolkit change should go into
XToolkit.java.


It's likely I'm missing something.  If it does make sense to bless a
particular lightweight component implementation, then this should be
dealt with in Classpath first.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]