This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch for Review: libjava Configury Changes for Cross Builds
- From: Andrew Haley <aph at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, rmathew at hotmail dot com
- Date: Sun, 27 Apr 2003 09:47:58 +0100
- Subject: Patch for Review: libjava Configury Changes for Cross Builds
- References: <2WNJ4YIDLF5Y51PMSQYSM623Y72762W.3eab9493@p733>
I'm not going to analyze this patch, because configury is not my main
area of expertise.
However, I have one comment to make. When you have carefully analyzed
a problem and come up with a solution that still needs some caveats,
please add some commentary *to the files in question*. This mail will
probably be missed by future maintenance programmers, but if you add
comments to the files your efforts won't be wasted. Besides, you've
already written this stuff, so adding it to the configure files is
almost a cut 'n paste.
Andrew.