This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: S/390: Fix backtrace support for Java
- From: Ulrich Weigand <weigand at immd1 dot informatik dot uni-erlangen dot de>
- To: hp at bitrange dot com (Hans-Peter Nilsson)
- Cc: weigand at immd1 dot informatik dot uni-erlangen dot de (Ulrich Weigand), gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Wed, 2 Apr 2003 18:55:35 +0200 (MET DST)
- Subject: Re: S/390: Fix backtrace support for Java
Hans-Peter Nilsson wrote:
> On Sat, 29 Mar 2003, Ulrich Weigand wrote:
> > libjava/ ChangeLog:
> >
> > * configure.in (HAVE_BACKTRACE) [s390*-*-linux*]: Define.
>
> A common changelog error: that means something else (see
> GNU coding standards). Should be
>
> > * configure.in (HAVE_BACKTRACE) <s390*-*-linux*>: Define.
Hmmm. According to the GNU Coding Standards, <> indicates
"the part of a function which changed", while [] indicate
"the conditions for which the change applies".
In this case, what the change does is to define HAVE_BACKTRACE
when compiling for a s390*-*-linux* target; to me this is more
like a condition than a part (what part? this define is simply
set or not).
Now, both the <> and the [] description details refer to
particulars of C source code that do not strictly apply
to configure scripts, so I guess one can argue about how
those concepts are supposed to be transferred ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
weigand at informatik dot uni-erlangen dot de