This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: BigInteger patch (long)
- From: Per Bothner <per at bothner dot com>
- To: raif at fl dot net dot au
- Cc: tromey at redhat dot com, java-patches at gcc dot gnu dot org
- Date: Fri, 31 Jan 2003 18:40:42 -0800
- Subject: Re: BigInteger patch (long)
- References: <200212262244.25772.raif@fl.net.au> <87znphvt1z.fsf@fleche.redhat.com> <200302011336.30199.raif@fl.net.au>
The ChangeLog is a little too everything-and-the-
kitchen-sink-too. Changes that are more-or-less
separate should be listed separately. For example:
* java/math/BigInteger.java (isOdd, isMinusOne, ...)
Removed usused methods.
* java/math/BigInteger.java: Reduce the number of
temporaries created by euclidInv.
(euclidInv(int,int,int): Now returns ...
* java/math/BigInteger.java: Various style changes:
pow(int): Removed 'else' keyword.
...
* java/math/BigInteger.java (make): Remove private field.
Instead "inline" it into valueOf.
(bitOp(int,BI,BI)): Use valueOf(long) instead of make(long).
Note the parens before the method names when before the colon.
Note the blank lines between logically separate changes.
Note also we don't normally add the extra 2 spaces of indentation.
Note since you're editing libjava/ChangeLog there
is no need to least libjava/java ...
I assume you have an assignment with the FSF?
--
--Per Bothner
per@bothner.com http://www.bothner.com/per/