Re: {Patch] java.net network functions

[Richard Earnshaw <rearnsha at arm dot com>]

> >>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
> 
> Michael> I just moved code to a different location. I really wonder
> Michael> how that can break this way.
> 
> A couple notes here.
> 
> First, please post patches outside of java.net for approval.
> 
> Second, all patches must be posted to the list, even patches that fix
> a bug introduced by an earlier patch.  So for instance the two changes
> coming out of this discussion should have been posted.  The only
> exception to this rule is reverting an erroneous commit.
> 
> 
> It might be time for us to think about stabilizing what we have in
> preparation for the upcoming 3.3 release.  I couldn't find the release
> schedule right now, but I'll try again.  One option for us would be to
> make a temporary branch where we could check in changes pending the
> creation of the 3.3 branch.
> 
> Tom

Unfortunately this is still broken...

/work/rearnsha/gnu/egcs/gcc/xgcc -shared-libgcc -B/work/rearnsha/gnu/egcs/g
cc/ -nostdinc++ -L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src 
-L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src/.libs -nostdinc 
-B/work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/ -isystem 
/work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/targ-include -isystem 
/home/rearnsha/gnusrc/egcs-cross/newlib/libc/include 
-B/work/rearnsha/gnu/install/arm-elf/bin/ -B/work/rearnsha/gnu/install/arm-
elf/lib/ -isystem /work/rearnsha/gnu/install/arm-elf/include 
-L/work/rearnsha/gnu/egcs/ld -mthumb -DHAVE_CONFIG_H -I. 
-I/home/rearnsha/gnusrc/egcs-cross/libjava -I./include -I./gcj 
-I/home/rearnsha/gnusrc/egcs-cross/libjava -Iinclude 
-I/home/rearnsha/gnusrc/egcs-cross/libjava/include 
-I/home/rearnsha/gnusrc/egcs-cross/libjava/../boehm-gc/include -DSILENT=1 
-DNO_SIGNALS=1 -DNO_EXECUTE_PERMISSION=1 -DALL_INTERIOR_POINTERS=1 
-DJAVA_FINALIZATION=1 -DGC_GCJ_SUPPORT=1 -DATOMIC_UNCOLLECTABLE=1 
-DNO_SIGSET=1 -DNO_DEBUGGING=1 -I/home/rearnsha/gnusrc/egcs-cross/libjava/.
././libjava/../gcc -I/home/rearnsha/gnusrc/egcs-cross/libjava/../zlib 
-fno-rtti -fnon-call-exceptions -fdollars-in-identifiers -Wswitch-enum 
-I/usr/X11R6/include -W -Wall -D_GNU_SOURCE -DPREFIX=\"/work/rearnsha/gnu/i
nstall\" -g -O2 -mthumb -MD -MT java/io/natFileDescriptor.lo -MF 
java/io/natFileDescriptor.pp -c java/io/natFileDescriptor.cc -o 
java/io/natFileDescriptor.o
java/io/natFile.cc: In member function `jboolean 
   java::io::File::_access(__java_int)':
java/io/natFile.cc:41: warning: unused parameter `jint query'
java/io/natFile.cc: In member function `jlong java::io::File::attr(__java_i
nt)
   ':
java/io/natFile.cc:85: warning: unused parameter `jint query'
java/io/natFile.cc: In member function `virtual java::lang::String* 
   java::io::File::getCanonicalPath()':
java/io/natFile.cc:110: warning: unused variable `char buf2[1024]'
java/io/natFile.cc: In member function `JArray<java::lang::Object*>* 
   java::io::File::performList(java::io::FilenameFilter*, 
   java::io::FileFilter*, java::lang::Class*)':
java/io/natFile.cc:141: warning: unused parameter `
   java::io::FilenameFilter*filter'
java/io/natFile.cc:141: warning: unused parameter `
   java::io::FileFilter*fileFilter'
java/io/natFile.cc:141: warning: unused parameter `
   java::lang::Class*result_type'
java/io/natFileDescriptor.cc: In member function `jint 
   java::io::FileDescriptor::open(java::lang::String*, __java_int)':
java/io/natFileDescriptor.cc:125: error: `_Jv_platform_close_on_exec' 
   undeclared (first use this function)
java/io/natFileDescriptor.cc:125: error: (Each undeclared identifier is 
   reported only once for each function it appears in.)
java/io/natFileDescriptor.cc: In member function `void 

etc, etc.

Michael, it would really help if you could set up a cross build 
environment so that you can test these issues before you install your 
changes.

R.