This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: FYI: jni.cc fixes


Tom Tromey wrote:

>+      JvAssert (sizeof (int) >= sizeof (jint));
>+      JvAssert (sizeof (jlong) >= sizeof (int));
>+      JvAssert (sizeof (float) >= sizeof (jfloat));
>+      JvAssert (sizeof (double) >= sizeof (jdouble));

Well, these assumptions hold on s390/s390x.

Though I'm not sure exactly why the sizeof (float) >= 
sizeof (jfloat) is necessary; shouldn't this be rather 
sizeof (double) >= sizeof (jfloat)?  What you want to 
check is that both jfloat and jdouble are equal to either 
float or double (both of which are passed as double).

In any case, you didn't actually change the broken va_arg,
did you?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  weigand@informatik.uni-erlangen.de


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]