This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: java.net.DatagramSocketImplFactory - new class


>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Hi Michael.

Michael> /**
Michael>   * This method returns an instance of the DatagramSocketImpl object
Michael>   *
Michael>   * @return A DatagramSocketImpl object
Michael>   */
Michael> DatagramSocketImpl
Michael> createDatagramSocketImpl();

New classes should conform to our indentation style.
So this should be indented like so:

  /**
    * This method returns an instance of the DatagramSocketImpl object
    *
    * @return A DatagramSocketImpl object
    */
  DatagramSocketImpl createDatagramSocketImpl();

That is, all on one lines, indented two spaces.
(Socket.java is an ok example to look at if you want to see one.)

Other than that this is fine, please check it in.
Thanks again for all your java.net work.  Please add yourself to the
THANKS file.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]