This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: StackTraceElement support


Hi,

On Thu, 2002-07-11 at 19:52, Andrew Haley wrote:
> Your patch isn't as robust as the previous code in that it now fails
> to produce any useful output if addr2line or c++filt are absent.
> These executables aren't always present, and it's important to produce
> some sort of stack trace if at all possible.  I hacked your patch
> about a bit to re-introduce that robustness.
> 
> See what you think -- if you agree with what I've done, please check
> it in.

Thanks I had forgotten to test that case.
Also thanks for the two little string handling logic cleanups.
I am checking in your version (with a fixed gcj/javaprims.h).

> FYI: I'm thinking of getting rid of the call to c++filt altogether --
> it's not needed because addr2line will work on shared objects and can
> now produce Java demangling.  That gets us line numbers in shared
> objects too.  Bonus...

I thought about that but some versions of addr2line know only about -C
and that will only demangle to C++ syntax.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]