This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch for java/parse.y handling of empty strings
- From: Mark Wielaard <mark at klomp dot org>
- To: tromey at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, Alexandre Petit-Bianco <apbianco at redhat dot com>
- Date: 28 Apr 2002 10:30:56 +0200
- Subject: Re: Patch for java/parse.y handling of empty strings
- References: <1019113264.7866.204.camel@elsschot> <87pu0qdqwh.fsf@creche.redhat.com>
Hi,
On Tue, 2002-04-23 at 23:52, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
>
> Mark> 2002-04-17 Mark Wielaard <mark@klomp.org>
> Mark> * parse.y (build_string_concatenation): Return just op1 only when op2
> Mark> is null and op1 is a STRING_CST, otherwise always construct a
> Mark> StringBuffer.
>
> Did this ever get reviewed?
No.
> It isn't a regression, but it does seem like a reasonable, low-risk
> fix to me.
> At this point we would need approvals from both Alex and Mark.
It is now to late for 3.1 I guess, but it still is an important bug fix
and it would be nice to get it into 3.2 (and maybe later 3.1.1).
Cheers,
Mark