This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: PR java/5848
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- To: tromey at redhat dot com
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 6 Mar 2002 22:40:05 -0800 (PST)
- Subject: Re: Patch: PR java/5848
- References: <87it891895.fsf@creche.redhat.com>
- Reply-to: apbianco at redhat dot com
Tom Tromey writes:
> Frankly this patch feels like a hack. It seems to be in the spirit
> of this function, in that it handles another case by unwrapping
> extraneous layers of trees. However, I'm concerned because there
> might very well be other cases that ought to be handled here.
This is the kind of thing the needs to be re-written, because it's the
implementation is sub optimal and not in the spirit of what is done in
the rest of the compiler (we ought to use COMPONENT_REF.)
> I'm going to rebuild libgcj with this shortly. Meanwhile, Alex,
> what do you think?
It looks OK. For this kind of cases, I'd like to run it through my set
of tests before we check it in, especially since I think we should
check that into the 3.1 branch.
./A