This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: WIN-28.1: fix POSIX file descriptor numbering assumptions

>>>>> "Adam" == Adam Megacz <patches@lists.megacz.com> writes:

Adam> Index: natFileDescriptorEcos.cc
 
Adam> +void
Adam> +java::io::FileDescriptor::init(void)
Adam> +{
Adam> +  in = new java::io::FileDescriptor((jint)(GetStdHandle (0)));
Adam> +  out = new java::io::FileDescriptor((jint)(GetStdHandle (1)));
Adam> +  err = new java::io::FileDescriptor((jint)(GetStdHandle (2)));
Adam> +}

Shouldn't these just be `0', `1', `2'?

Adam> Index: natFileDescriptorPosix.cc
Adam> +void
Adam> +java::io::FileDescriptor::init(void)
Adam> +{
Adam> +  in = new java::io::FileDescriptor((jint)(GetStdHandle (0)));
Adam> +  out = new java::io::FileDescriptor((jint)(GetStdHandle (1)));
Adam> +  err = new java::io::FileDescriptor((jint)(GetStdHandle (2)));
Adam> +}

Likewise.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]