This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]


Adam Megacz wrote:

>// Read the socket.
>-  int r = _Jv_recv (::recv, fnum, (void *) bytes, count, 0);
>+  int r = _Jv_recv ((int (*)(unsigned int, char*, int, int))(::recv),
>+		    fnum, (void *) bytes, count, 0);
>   if (r == 0)
>     return -1;
>   if (java::lang::Thread::interrupted())
>

I don't like the look of this bit ;-(. The _Jv_recv thing seems to break 
one platform or another every time someone changes it. Then again I 
always thought it was a bit of a hack, perhaps it would be better to 
just do some configure tests after all. Why did you need to add the casting?

regards

Bryce.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]