Re: java.lang.Character

[Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>]

Eric Blake wrote:

>Followup: is this ok to commit?  Also, do I need to add --help and
>--version command-line arguments to the two perl scripts, seeing that
>they are only going to be on CVS and not in a distribution?
>

I'll defer to Tom to review this one, since I'm sure he's more familiar 
with the Character/Unicode stuff than me. The implementation definatly 
looks better, in terms of performance, than what we have now.

One small concern I have is that having these tables as Strings (as 
opposed to char[]) is going to increase startup cost and memory usage 
because the runtime must copy them and do a utf8->utf16(?) conversion 
during initialization, while if they were char[] they would stay in 
shared pages and not require initialization. Why use Strings?

libgcj has a different java.lang.String implementation to classpath, and 
it doesn't look like this code will work without changing something (eg 
String.data -> String.value)

The old java-chardata.h etc can be deleted when this patch goes in.

regards

Bryce.