This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -classpath switch patch



Nic Ferrier writes:

> Attached is the patch for the classpath switch stuff.

Thanks.

> Here's a changelog description:         
> 
>         * gcc/java/gcj.texi (Input options): ditto.

Remove the `gcc/java/.' This is for gcc/java/ChangeLog but seems to
refer to an earlier entry in gcc/ChangeLog. Since things aren't linked
in any ways, you'll have to say what one more time what you're doing
in gcj.texi (I remember crafting an entry saying explaining how flags
where swapped.) 

>         * gcc/java/gjavah.c (struct option, help, main): ditto.

You'll have to capitalize after the `:'.

>         * jcf.h, jcf-path.c (struct entry): change meaning of options.

One entry per file -- this might look like pointless nitpicking, but
ChangeLog entries are invaluable source of information and need to be
written carefully. One thing to remember is that they're used to
explain what you're doing in/with the code (not why you're doing it,
as this should be a comment in the code.)

> Comments are most welcome (including about the format of my
> changelog entry).

If you still have what I sent to you the other day (I'm not able to
find it anymore :-(), I would advise that you use it. 

There's still a gcc part, right?

./A


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]