This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: WIN-18: remove exception.cc dependancy on libstdc++-v3 headers


>>>>> "Adam" == Adam Megacz <patches@lists.megacz.com> writes:

Adam> 2) Hack a std::abort() before #including unwind-pe.h, since unwind-pe
Adam>    assumes that if you're compiling with a C++ compiler, you
Adam>    automatically must have libstdc++-v3 available (faulty assumption,
Adam>    IMHO).

Adam> Ok to commit?

Please make a couple changes first:

1. Add a comment before the `namespace std' explaining why we need this.
   This is the sort of oddity we must document in the source.

Adam> +namespace std {
Adam> +  void
Adam> +  abort()
Adam> +  {
Adam> +    ::abort();
Adam> +  }
Adam> +}

2. I think this should be formatted:

    namespace std
    {
      void abort ()
      {
	 ::abort ();
      }
    }


Thanks,
Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]